Add imagen editing cases to the Firebase AI quickstart #2702
+196
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmotson
changed the title
ryanwilson
reviewed
Jul 23, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/MainActivity.kt
Outdated
Show resolved
Hide resolved
|
Please add a description to the PR |
rlazo
reviewed
Jul 23, 2025
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt
Show resolved
Hide resolved
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
...-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenScreen.kt
Outdated
Show resolved
Hide resolved
.../app/src/main/java/com/google/firebase/quickstart/ai/feature/media/imagen/ImagenViewModel.kt
Outdated
Show resolved
Hide resolved
thatfiredev
requested changes
Aug 6, 2025
| val tools: List<Tool>? = null, | ||
| val includeAttach: Boolean = false, | ||
| val allowEmptyPrompt: Boolean = false, | ||
| val generateImages: (suspend (ImagenModel, String, Bitmap?) -> ImagenGenerationResponse<ImagenInlineImage>)? = null |
There was a problem hiding this comment.
Rather than passing a suspend function here, what if we pass the List<ImagenReferenceImage> and prompt?
There was a problem hiding this comment.
That may not work as an abstraction, sometimes editing settings also need to be set, basically every parameter, depending on the use case.
| @@ -36,6 +39,7 @@ class MainActivity : ComponentActivity() { | |||
| override fun onCreate(savedInstanceState: Bundle?) { | |||
| super.onCreate(savedInstanceState) | |||
| enableEdgeToEdge() | |||
| catImage = BitmapFactory.decodeResource(applicationContext.resources, R.drawable.cat) | |||
There was a problem hiding this comment.
Can we move the Imagen editing features to a new screen+viewmodel ?
And we can load this bitmap from there, rather than from the MainActivity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Imagen Editing cases to the quickstart including: